-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Backport macOS 26 Tahoe test fixes to release/9.0-staging #119716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport macOS 26 Tahoe test fixes to release/9.0-staging #119716
Conversation
Backport dotnet#118777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports test fixes for macOS 26 Tahoe compatibility to the release/9.0-staging branch. The changes address test failures that occurred when running against macOS 26 RC by updating platform detection logic and adjusting test expectations for certificate chain validation behavior on newer Apple platforms.
Key changes:
- Added platform detection for Apple platforms version 26 or later
- Updated certificate chain test expectations to handle behavioral differences in macOS 26
- Modified test logic to group Linux and Apple 26+ platforms with similar behavior patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs | Adds new property to detect Apple platforms version 26 or later |
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs | Updates certificate chain test expectations for macOS 26 compatibility |
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs
Show resolved
Hide resolved
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Test-only change, applying servicing-approved under tell-mode. |
I've given that timing out pipeline 4 tries, not really sure a 5th is going to work. |
/ba-g Unrelated timeout |
Updated [Microsoft.Extensions.DependencyInjection](https://github.com/dotnet/runtime) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.DependencyInjection's releases](https://github.com/dotnet/runtime/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/runtime/releases/tag/v9.0.9) ## What's Changed * [release/9.0-staging] Disable release assert on disallowed thread re-initialization for managed C++ by @github-actions[bot] in dotnet/runtime#118842 * [release/9.0-staging] [wasm][AOT] fix codegen for small structs on stack by @github-actions[bot] in dotnet/runtime#118416 * Update branding to 9.0.10 by @vseanreesermsft in dotnet/runtime#119280 * [release/9.0-staging] Don't use vfork on android by @github-actions[bot] in dotnet/runtime#118331 * [release/9.0-staging] [mono][debugger] Fix assertion when stepping by @github-actions[bot] in dotnet/runtime#118459 * [release/9.0-staging][maccatalyst] Check for -Wno-overriding-option for compatibility with clang in Xcode 16.3+ by @akoeplinger in dotnet/runtime#119301 * [release/9.0-staging][HTTP] Stress fix for docker compose by @ManickaP in dotnet/runtime#119455 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/runtime#119505 * [9.0] Preserve Lock ID Members by @jkoritzinsky in dotnet/runtime#119281 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#118940 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#118151 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#118372 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#118423 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#118193 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#118758 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119619 * [release/9.0-staging] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/runtime#119598 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119620 * [release/9.0-staging] Update dependencies from dotnet/xharness by @dotnet-maestro[bot] in dotnet/runtime#119051 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#118492 * [release/9.0-staging] [H/3] Fix interop tests. by @github-actions[bot] in dotnet/runtime#119522 * [release/9.0-staging] Disable tests parallelization in flaky OleDB tests by @github-actions[bot] in dotnet/runtime#119626 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119690 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#118224 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#119677 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#119635 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119669 * [release/9.0-staging] Fix recursion issue found in PROCCreateCrashDump by @github-actions[bot] in dotnet/runtime#119128 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119742 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#119721 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119753 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119793 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119809 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119832 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#119830 * Backport macOS 26 Tahoe test fixes to release/9.0-staging by @vcsjones in dotnet/runtime#119716 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#119871 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119872 * [release/9.0-staging] Disable Multicast SocketOption test by @github-actions[bot] in dotnet/runtime#119889 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119932 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119900 * [manual] Merge release/9.0-staging into release/9.0 by @tarekgh in dotnet/runtime#119966 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120025 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120111 **Full Changelog**: dotnet/runtime@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/runtime@v9.0.9...v9.0.10). </details> Updated [Microsoft.Extensions.Logging](https://github.com/dotnet/runtime) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.Logging's releases](https://github.com/dotnet/runtime/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/runtime/releases/tag/v9.0.9) ## What's Changed * [release/9.0-staging] Disable release assert on disallowed thread re-initialization for managed C++ by @github-actions[bot] in dotnet/runtime#118842 * [release/9.0-staging] [wasm][AOT] fix codegen for small structs on stack by @github-actions[bot] in dotnet/runtime#118416 * Update branding to 9.0.10 by @vseanreesermsft in dotnet/runtime#119280 * [release/9.0-staging] Don't use vfork on android by @github-actions[bot] in dotnet/runtime#118331 * [release/9.0-staging] [mono][debugger] Fix assertion when stepping by @github-actions[bot] in dotnet/runtime#118459 * [release/9.0-staging][maccatalyst] Check for -Wno-overriding-option for compatibility with clang in Xcode 16.3+ by @akoeplinger in dotnet/runtime#119301 * [release/9.0-staging][HTTP] Stress fix for docker compose by @ManickaP in dotnet/runtime#119455 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/runtime#119505 * [9.0] Preserve Lock ID Members by @jkoritzinsky in dotnet/runtime#119281 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#118940 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#118151 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#118372 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#118423 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#118193 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#118758 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119619 * [release/9.0-staging] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/runtime#119598 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119620 * [release/9.0-staging] Update dependencies from dotnet/xharness by @dotnet-maestro[bot] in dotnet/runtime#119051 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#118492 * [release/9.0-staging] [H/3] Fix interop tests. by @github-actions[bot] in dotnet/runtime#119522 * [release/9.0-staging] Disable tests parallelization in flaky OleDB tests by @github-actions[bot] in dotnet/runtime#119626 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119690 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#118224 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#119677 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#119635 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119669 * [release/9.0-staging] Fix recursion issue found in PROCCreateCrashDump by @github-actions[bot] in dotnet/runtime#119128 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119742 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#119721 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119753 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119793 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119809 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119832 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#119830 * Backport macOS 26 Tahoe test fixes to release/9.0-staging by @vcsjones in dotnet/runtime#119716 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#119871 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119872 * [release/9.0-staging] Disable Multicast SocketOption test by @github-actions[bot] in dotnet/runtime#119889 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119932 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119900 * [manual] Merge release/9.0-staging into release/9.0 by @tarekgh in dotnet/runtime#119966 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120025 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120111 **Full Changelog**: dotnet/runtime@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/runtime@v9.0.9...v9.0.10). </details> Updated [Microsoft.Extensions.Logging.Debug](https://github.com/dotnet/runtime) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.Logging.Debug's releases](https://github.com/dotnet/runtime/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/runtime/releases/tag/v9.0.9) ## What's Changed * [release/9.0-staging] Disable release assert on disallowed thread re-initialization for managed C++ by @github-actions[bot] in dotnet/runtime#118842 * [release/9.0-staging] [wasm][AOT] fix codegen for small structs on stack by @github-actions[bot] in dotnet/runtime#118416 * Update branding to 9.0.10 by @vseanreesermsft in dotnet/runtime#119280 * [release/9.0-staging] Don't use vfork on android by @github-actions[bot] in dotnet/runtime#118331 * [release/9.0-staging] [mono][debugger] Fix assertion when stepping by @github-actions[bot] in dotnet/runtime#118459 * [release/9.0-staging][maccatalyst] Check for -Wno-overriding-option for compatibility with clang in Xcode 16.3+ by @akoeplinger in dotnet/runtime#119301 * [release/9.0-staging][HTTP] Stress fix for docker compose by @ManickaP in dotnet/runtime#119455 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/runtime#119505 * [9.0] Preserve Lock ID Members by @jkoritzinsky in dotnet/runtime#119281 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#118940 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#118151 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#118372 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#118423 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#118193 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#118758 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119619 * [release/9.0-staging] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/runtime#119598 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119620 * [release/9.0-staging] Update dependencies from dotnet/xharness by @dotnet-maestro[bot] in dotnet/runtime#119051 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#118492 * [release/9.0-staging] [H/3] Fix interop tests. by @github-actions[bot] in dotnet/runtime#119522 * [release/9.0-staging] Disable tests parallelization in flaky OleDB tests by @github-actions[bot] in dotnet/runtime#119626 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119690 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#118224 * [release/9.0-staging] Update dependencies from dotnet/runtime-assets by @dotnet-maestro[bot] in dotnet/runtime#119677 * [release/9.0-staging] Update dependencies from dotnet/hotreload-utils by @dotnet-maestro[bot] in dotnet/runtime#119635 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119669 * [release/9.0-staging] Fix recursion issue found in PROCCreateCrashDump by @github-actions[bot] in dotnet/runtime#119128 * [release/9.0-staging] Update dependencies from dotnet/cecil by @dotnet-maestro[bot] in dotnet/runtime#119742 * [automated] Merge branch 'release/9.0' => 'release/9.0-staging' by @github-actions[bot] in dotnet/runtime#119721 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119753 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119793 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119809 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119832 * [release/9.0-staging] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/runtime#119830 * Backport macOS 26 Tahoe test fixes to release/9.0-staging by @vcsjones in dotnet/runtime#119716 * [release/9.0-staging] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#119871 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119872 * [release/9.0-staging] Disable Multicast SocketOption test by @github-actions[bot] in dotnet/runtime#119889 * [release/9.0-staging] Update dependencies from dotnet/icu by @dotnet-maestro[bot] in dotnet/runtime#119932 * [release/9.0] Update dependencies from dotnet/emsdk by @dotnet-maestro[bot] in dotnet/runtime#119900 * [manual] Merge release/9.0-staging into release/9.0 by @tarekgh in dotnet/runtime#119966 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120025 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/runtime#120111 **Full Changelog**: dotnet/runtime@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/runtime@v9.0.9...v9.0.10). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Backport #118652
Backport #118777
Customer Impact
None, test only change.
Regression
Testing
These tests were failing against macOS 26 RC. They now pass against macOS 26 RC.
Risk
None, test only change.